Bug fix for hyprctl --batch doesn't work with exec rules #8952
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixing command parsing to ignore ';' inside []
vaxerski
reviewed
Jan 4, 2025
vaxerski
reviewed
Jan 5, 2025
vaxerski
approved these changes
Jan 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your PR, what does it fix/add?
Fixes #1820 by ignoring ';' inside brackets [ ]
Is there anything you want to mention? (unchecked code, possible bugs, found problems, breaking compatibility, etc.)
For some reason the only app that was problematic when testing using commands like this ->
hyprctl --batch 'dispatch exec [noanim;float;workspace 7 silent] appname; dispatch exec [noanim;float;workspace 6 silent] appname; dispatch exec appname;'was Wezterm, it would spawn on whatever workspace, other than that everything else worked without issues
Is it ready for merging, or does it need work?
Yeah, I was testing it with different apps and different combinations of commands and as mentioned above only Wezterm was problematic